Meltdown exercise change according to issue #2565#2568
Merged
BethanyG merged 7 commits intoexercism:mainfrom Sep 17, 2021
Merged
Meltdown exercise change according to issue #2565#2568BethanyG merged 7 commits intoexercism:mainfrom
BethanyG merged 7 commits intoexercism:mainfrom
Conversation
Changes: - Change Task 2 intervals to cover non-integer comparison. - Rewrite tests to test more points, especially the border cases. - Reduce number of tests of only one per function, but test many points (asserts in loop) in each test. - Remove hints of integer input parameters (they can be any numeric type).
Remove python 3.8 debug f-string syntax for backwards compatibility.
BethanyG
reviewed
Sep 10, 2021
BethanyG
reviewed
Sep 10, 2021
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Member
|
Oh! And I almost forgot (which is terrible) -- please add a |
IsaacG
suggested changes
Sep 13, 2021
The parameter types can be either integers or floats. This is hinted with the Union type familiar with most of the current python users. (Can be replaced with | in the future and/or moved to :type: field of the docstring.)
BethanyG
reviewed
Sep 17, 2021
Member
|
@IsaacG -- Please don't recommend anything from |
Member
|
Bumping this to |
BethanyG
approved these changes
Sep 17, 2021
This was referenced Sep 22, 2021
This was referenced Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
(asserts in loop) in each test.